Separating out get_map_values helper from MapUnitX transform
#3313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69213291 |
SebastianAment
force-pushed
the
export-D69213291
branch
from
6c6c507 to
bf1f470
Compare
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Feb 6, 2025
…ebook#3313) Summary: This commit separates out a `get_map_values` helper function from the `MapUnitX` transform. Differential Revision: D69213291
|
This pull request was exported from Phabricator. Differential Revision: D69213291 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3313 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 533 533
Lines 52537 52556 +19
=======================================
+ Hits 50278 50297 +19
Misses 2259 2259 ☔ View full report in Codecov by Sentry. |
…ebook#3313) Summary: This commit separates out a `get_map_values` helper function from the `MapUnitX` transform. Reviewed By: saitcakmak Differential Revision: D69213291
SebastianAment
force-pushed
the
export-D69213291
branch
from
bf1f470 to
b487ad1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69213291 |
|
This pull request has been merged in 27bb656. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This commit separates out a
get_map_valueshelper function from theMapUnitXtransform.Differential Revision: D69213291